Reviewing for Code Reviews
Reviewing is the act of reading a change critically and deciding whether it is ready. It means checking correctness, edge cases, tests, naming, readability, performance and security, following a consistent process such as understanding intent first, then reading the diff, then testing or running it where needed.
Stage: Foundations · Part of the Code Review roadmap · Last reviewed 19 November 2026
What to learn in Reviewing
- Read the description and tests first to understand the intent of a change
- Check edge cases such as null input, empty lists and failure paths
- Judge whether tests actually cover the new behaviour
- Spot naming, duplication and complexity problems in a diff
- Decide between approve, request changes and comment-only
Reviewing interview questions
What do you look for first when reviewing a pull request?
Start with whether the change solves the stated problem and is designed sensibly, then correctness and edge cases, tests, security and maintainability. Style comes last and is best handled by automated tools so humans focus on logic.
How do you review code in a language or area you do not know well?
Focus on what you can judge: clarity, tests, naming, error handling and whether the approach makes sense. Ask questions where you are unsure, and say plainly which parts you did not review so a domain expert can cover them.
Where Reviewing fits in the Code Review roadmap
Reviewing belongs to the Foundations stage (beginner level), which takes about 8 hours. Why and how.
Other units in this stage
Back to the full Code Review roadmap